Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency cleanup #393

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dependency cleanup #393

wants to merge 3 commits into from

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented May 7, 2024

Running afew.py on a new system today and a few dependencies surprised me.

I have relegated matplotlib to only be imported when a plotting function is called. I have also added a hard dependency on pandas as several built-in modules use it.

That said, I also get the following message on my system, which is part of the reason I hate having pandas as a dependency:

/Users/bknueven/Software/mpi-sppy/mpisppy/extensions/phtracker.py:63: FutureWarning: The behavior of DataFrame concatenation with empty or all-NA entries is deprecated. In a future version, this will no longer exclude empty or all-NA columns when determining the result dtypes. To retain the old behavior, exclude the relevant entries before the concat operation.
  self.df = pd.concat([self.df, new_dict], ignore_index=True)

@bknueven bknueven requested a review from DLWoodruff May 7, 2024 21:51
@DLWoodruff
Copy link
Collaborator

We just merged a fix to the pandas deprecation warning; however, maybe we should also work to make pandas not a hard requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLWoodruff DLWoodruff Awaiting requested review from DLWoodruff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @DLWoodruff